Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polarArray start angle, and rotation fix (#1006) #1016

Merged
merged 2 commits into from
Mar 20, 2022

Conversation

lorenzncode
Copy link
Member

To resolve #1006.

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (5147dd8) to head (0e1d5b1).
Report is 374 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   96.27%   96.29%   +0.02%     
==========================================
  Files          40       40              
  Lines        9357     9364       +7     
  Branches     1103     1101       -2     
==========================================
+ Hits         9008     9017       +9     
+ Misses        205      204       -1     
+ Partials      144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

cadquery/cq.py Outdated Show resolved Hide resolved
cadquery/cq.py Outdated Show resolved Hide resolved
* Remove nested function
@adam-urbanczyk
Copy link
Member

Thanks @lorenzncode !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workplane polarArray incorrect startAngle and angle (according to its docstring and convention)
3 participants